From 2598bc2f6be0a3b4ce94dc4ef4676f883fab600b Mon Sep 17 00:00:00 2001 From: Xaver Maierhofer Date: Sat, 4 Feb 2017 03:01:17 +0100 Subject: [PATCH] [TASK] Remove sass lint exceptions --- .sass-lint.yml | 9 +-------- scss/modules/_base.scss | 17 +++++++++++++---- scss/modules/_infobox.scss | 3 ++- scss/modules/_legend.scss | 3 ++- scss/modules/_reset.scss | 1 + scss/modules/_sidebar.scss | 18 ++++++++++++------ scss/modules/_table.scss | 6 ++++-- scss/modules/_tabs.scss | 4 ++-- scss/night.scss | 3 ++- 9 files changed, 39 insertions(+), 25 deletions(-) diff --git a/.sass-lint.yml b/.sass-lint.yml index a7e4640..fadcfaa 100644 --- a/.sass-lint.yml +++ b/.sass-lint.yml @@ -1,9 +1,2 @@ rules: - single-line-per-selector: 0 - # Allow for new prefixes like -webkit-tap-highlight-color or antialiasing - # Can maybe be enabled again with sass-lint 1.8 https://github.com/sasstools/sass-lint/pull/709 - no-vendor-prefixes: 0 - # Needed for old 'display: -vendor-prefix-property' for higher browser-support - no-duplicate-properties: 0 - # Needed for unique-id() - empty-args: 0 +# No global rules currently diff --git a/scss/modules/_base.scss b/scss/modules/_base.scss index 97e659b..581c156 100644 --- a/scss/modules/_base.scss +++ b/scss/modules/_base.scss @@ -1,5 +1,5 @@ body { - -webkit-tap-highlight-color: transparent; + -webkit-tap-highlight-color: transparent; // sass-lint:disable-line no-vendor-prefixes background: $color-white; color: $color-black; font-family: $font-family; @@ -12,7 +12,12 @@ header { background: transparentize($color-black, .98); } -h1, h2, h3, h4, h5, h6 { +h1, +h2, +h3, +h4, +h5, +h6 { font-weight: bold; } @@ -31,12 +36,16 @@ h3 { padding: 1em 0; } -h2, h3 { +h2, +h3 { padding-left: $button-distance; padding-right: $button-distance; } -p, pre, ul, h4 { +p, +pre, +ul, +h4 { padding: 0 $button-distance 1em; } diff --git a/scss/modules/_infobox.scss b/scss/modules/_infobox.scss index b3f9fc5..3a66c45 100644 --- a/scss/modules/_infobox.scss +++ b/scss/modules/_infobox.scss @@ -4,7 +4,8 @@ font-family: $font-family-icons; } - input, textarea { + input, + textarea { border: 1px solid $color-gray-light; font-family: $font-family-monospace; font-size: 1.15em; diff --git a/scss/modules/_legend.scss b/scss/modules/_legend.scss index 11251d1..965848d 100644 --- a/scss/modules/_legend.scss +++ b/scss/modules/_legend.scss @@ -27,6 +27,7 @@ } } -.legend-online, .legend-offline { +.legend-online, +.legend-offline { margin-left: 1em; } diff --git a/scss/modules/_reset.scss b/scss/modules/_reset.scss index 11a108e..3aa7a09 100644 --- a/scss/modules/_reset.scss +++ b/scss/modules/_reset.scss @@ -1,5 +1,6 @@ // Eric Meyer's Reset CSS v2.0 (http://meyerweb.com/eric/tools/css/reset/) // http://cssreset.com +// sass-lint:disable-all html, body, div, span, applet, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, big, cite, code, diff --git a/scss/modules/_sidebar.scss b/scss/modules/_sidebar.scss index 4000d5a..11b2ffd 100644 --- a/scss/modules/_sidebar.scss +++ b/scss/modules/_sidebar.scss @@ -21,8 +21,10 @@ padding-bottom: 15px; } - .node-list, .node-links { - th, td { + .node-list, + .node-links { + th, + td { &:first-child { width: 25px; } @@ -38,7 +40,8 @@ } .node-links { - th, td { + th, + td { &:first-child { width: 50px; } @@ -46,7 +49,8 @@ } .link-list { - th, td { + th, + td { &:nth-child(1) { overflow: hidden; text-overflow: ellipsis; @@ -56,7 +60,8 @@ } } - .infobox, .container { + .infobox, + .container { @if $shadows == 1 { @include shadow(2); } @else { @@ -83,7 +88,8 @@ left: $sidebar-width-small + $button-distance; } - .container, .infobox { + .container, + .infobox { border-radius: 0; @if $shadows == 1 { box-shadow: none; diff --git a/scss/modules/_table.scss b/scss/modules/_table.scss index c3b8120..c40fc95 100644 --- a/scss/modules/_table.scss +++ b/scss/modules/_table.scss @@ -22,7 +22,8 @@ table { } } -td, th { +td, +th { line-height: 1.41em; text-align: right; @@ -61,7 +62,8 @@ th { } } - &.sort-up, &.sort-down { + &.sort-up, + &.sort-down { &::after { opacity: .4; visibility: visible; diff --git a/scss/modules/_tabs.scss b/scss/modules/_tabs.scss index 60f2781..ebffdfb 100644 --- a/scss/modules/_tabs.scss +++ b/scss/modules/_tabs.scss @@ -7,13 +7,13 @@ } background: transparentize($color-black, .98); display: flex; - display: -webkit-flex; + display: -webkit-flex; // sass-lint:disable-line no-vendor-prefixes no-duplicate-properties list-style: none; margin: 0; padding: 0; li { - -webkit-flex: 1 1 auto; + -webkit-flex: 1 1 auto; // sass-lint:disable-line no-vendor-prefixes color: transparentize($color-black, .5); cursor: pointer; flex: 1 1 auto; diff --git a/scss/night.scss b/scss/night.scss index a7c8bf3..304a31f 100644 --- a/scss/night.scss +++ b/scss/night.scss @@ -44,7 +44,8 @@ html { //@import 'modules/sidebar'; .sidebar { - .infobox, .container { + .infobox, + .container { background: transparentize($color-white, .03); border-right: 1px solid darken($color-white, 10%); }