correction + go deadlock

meshviewer/graph.go

@@ -50,7 +50,7 @@ func BuildGraph(nodes *runtime.Nodes) *Graph {
 		vpn:     make(map[string]interface{}),
 	}
 
-	builder.readNodes(nodes.List)
+	builder.readNodes(nodes)
 
 	graph := &Graph{Version: 1}
 	graph.Batadv.Directed = false
@@ -58,9 +58,12 @@ func BuildGraph(nodes *runtime.Nodes) *Graph {
 	return graph
 }
 
-func (builder *graphBuilder) readNodes(nodes map[string]*runtime.Node) {
+func (builder *graphBuilder) readNodes(nodes *runtime.Nodes) {
+	nodes.RLock()
+	defer nodes.RUnlock()
+
 	// Fill mac->id map
-	for sourceID, node := range nodes {
+	for sourceID, node := range nodes.List {
 		if nodeinfo := node.Nodeinfo; nodeinfo != nil {
 			// is VPN address?
 			if nodeinfo.VPN {
@@ -91,7 +94,7 @@ func (builder *graphBuilder) readNodes(nodes map[string]*runtime.Node) {
 	}
 
 	// Add links
-	for sourceID, node := range nodes {
+	for sourceID, node := range nodes.List {
 		if node.Online {
 			if neighbours := node.Neighbours; neighbours != nil {
 				// Batman neighbours

runtime/nodes.go

@@ -4,9 +4,10 @@ import (
 	"encoding/json"
 	"log"
 	"os"
-	"sync"
 	"time"
 
+	"github.com/sasha-s/go-deadlock"
+
 	"github.com/FreifunkBremen/yanic/data"
 	"github.com/FreifunkBremen/yanic/jsontime"
 )
@@ -15,7 +16,7 @@ import (
 type Nodes struct {
 	List   map[string]*Node `json:"nodes"` // the current nodemap, indexed by node ID
 	config *Config
-	sync.RWMutex
+	deadlock.RWMutex
 }
 
 // NewNodes create Nodes structs

runtime/stats.go

@@ -23,7 +23,7 @@ func NewGlobalStats(nodes *Nodes) (result *GlobalStats) {
 		Models:    make(CounterMap),
 	}
 
-	nodes.Lock()
+	nodes.RLock()
 	for _, node := range nodes.List {
 		if node.Online {
 			result.Nodes++
@@ -42,7 +42,7 @@ func NewGlobalStats(nodes *Nodes) (result *GlobalStats) {
 			}
 		}
 	}
-	nodes.Unlock()
+	nodes.RUnlock()
 	return
 }