nils/gluon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gluon-web-model: remove unused field error message code

Browse Source 
Validation errors are mostly handled in the frontend (by displaying
invalid fields with a red background). There was some code left in the
backend for handling different kinds of errors, and returning custom
error messages from validate(), but the resulting value was not used
anywhere.
This commit is contained in:
Matthias Schiffer 2020-05-08 22:24:43 +02:00
parent f4f49b1fcb
commit ac93718a55
No known key found for this signature in database
GPG Key ID: 16EF3F64CB201D9C
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
package/gluon-web-model/luasrc/usr/lib/lua/gluon/web/model/classes.lua
View File

@ -131,6 +131,7 @@ function AbstractValue:__init__(...)
self.template = "model/valuewrapper"
self.error = false
self.state = M.FORM_NODATA
end
@ -177,14 +178,9 @@ function AbstractValue:cfgvalue()
end
end
function AbstractValue:add_error(type, msg)
self.error = msg or type
self.state = M.FORM_INVALID
end
function AbstractValue:reset()
self.error = nil
self.data = nil
self.error = false
self.state = M.FORM_NODATA
end
@ -192,13 +188,9 @@ end
function AbstractValue:parse(http)
self.data = self:formvalue(http)
local ok, err = self:validate()
if not ok then
if type(self.data) ~= "string" or #self.data > 0 then
self:add_error("invalid", err)
else
self:add_error("missing", err)
end
if not self:validate() then
self.error = true
self.state = M.FORM_INVALID
return
end