From d0df47d9433ccdeac54944c812e497a45919f8f9 Mon Sep 17 00:00:00 2001 From: Sven Eckelmann Date: Mon, 25 Feb 2019 22:43:23 +0100 Subject: [PATCH] gluon-status-page-mesh-batman-adv: Retrieve TQ of neighbors with non-best direct link Links between two direct neighbors are not always the best route between these devices. The flag BATADV_ATTR_FLAG_BEST would not be set for these originator entries and the respondd module would just ignore this entry. If these neighbors are not accepted and returned to the status page then some of the neighbor entries will show a name, (acceptable) signal strength and mac address but no TQ value. Fixes: 28668c8c5218 ("gluon-status-page: API") --- .../gluon-status-page-mesh-batman-adv/src/neighbours-batadv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/package/gluon-status-page-mesh-batman-adv/src/neighbours-batadv.c b/package/gluon-status-page-mesh-batman-adv/src/neighbours-batadv.c index b923d7f1..53b99046 100644 --- a/package/gluon-status-page-mesh-batman-adv/src/neighbours-batadv.c +++ b/package/gluon-status-page-mesh-batman-adv/src/neighbours-batadv.c @@ -54,9 +54,6 @@ static int parse_orig_list_netlink_cb(struct nl_msg *msg, void *arg) BATADV_ARRAY_SIZE(parse_orig_list_mandatory))) return NL_OK; - if (!attrs[BATADV_ATTR_FLAG_BEST]) - return NL_OK; - orig = nla_data(attrs[BATADV_ATTR_ORIG_ADDRESS]); dest = nla_data(attrs[BATADV_ATTR_NEIGH_ADDRESS]); tq = nla_get_u8(attrs[BATADV_ATTR_TQ]);