nils/gluon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not have the ugly "-e" printed for CheckTarget

Browse Source 
The "echo -e" is executed in a newly spawned shell (the enclosing ()s). That shell by default is a bourne shell. And that has a built-in echo that fails to understand the -e option and just prints it. Same for dash. If you set a SHELL=/bin/bash then this would also solve the issue. I had felt that by explicitly executing the binary echo implementation this would be the easiest to grasp. Well. Make your pick.
This commit is contained in:
Steffen Möller 2016-03-22 12:30:45 +01:00
parent 7327ad2ff1
commit fea8144557
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -53,7 +53,7 @@ include $(GLUONDIR)/targets/targets.mk
CheckTarget := [ -n '$(GLUON_TARGET)' -a -n '$(GLUON_TARGET_$(GLUON_TARGET)_BOARD)' ] \ CheckTarget := [ -n '$(GLUON_TARGET)' -a -n '$(GLUON_TARGET_$(GLUON_TARGET)_BOARD)' ] \
|| (echo -e 'Please set GLUON_TARGET to a valid target. Gluon supports the following targets:$(subst $(space),\n * ,$(GLUON_TARGETS))'; false) || (/bin/echo -e 'Please set GLUON_TARGET to a valid target. Gluon supports the following targets:$(subst $(space),\n * ,$(GLUON_TARGETS))'; false)
CheckExternal := test -d $(GLUON_ORIGOPENWRTDIR) || (echo 'You don'"'"'t seem to have obtained the external repositories needed by Gluon; please call `make update` first!'; false) CheckExternal := test -d $(GLUON_ORIGOPENWRTDIR) || (echo 'You don'"'"'t seem to have obtained the external repositories needed by Gluon; please call `make update` first!'; false)