a modular framework for creating OpenWrt-based firmwares for wireless mesh nodes
afce06c3d3
Using the line ``` * * * * echo "foobar" ``` (notice the missing fifth time field) in a crontab causes gluon-cron to enter an endless loop while parsing it, thus it won't even execute the other, valid crontabs. This is caused by the loop in [line 138] where `begin - min` substracts the unsigned `min` from the signed `begin`. If now `begin` is invalid, `strict_atoi` returns -1 and the loop starts at `(-1)-1=MAX_INT` and runs while `i <= MAX_INT` which is always true. The real culprit lies in [line 134] where exactly this case `begin < min` is checked - but because of the signedness, this check doesn't work as expected either. The easiest solution is to make `min` a signed integer instead of an unsigned one, as we do not require it to be very large and only pass the constants 0 or 1 to it. To avoid other similar problems, this patch makes the input variable `n` a signed integer as well. |
||
|---|---|---|
| package | ||